Re: [PATCH v2 8/9] spi: spi-s3c64xx: Increase transfer timeout

From: Krzysztof Kozlowski
Date: Sat Aug 22 2020 - 08:44:03 EST


On Fri, Aug 21, 2020 at 06:14:00PM +0200, Łukasz Stelmach wrote:
> Increase timeout by 30 ms for some wiggle and set the minimum value to
> 100 ms. This ensures a non-zero value for short transfers which
> may take less than 1 ms. The timeout value does not affect
> performance because it is used with a completion.
>
> Similar formula is used in other drivers e.g. sun4i, sun6i.
>
> Signed-off-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
> ---
> drivers/spi/spi-s3c64xx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>

Best regards,
Krzysztof