Re: [PATCH bpf-next v4 28/30] bpf: eliminate rlimit-based memory accounting infra for bpf maps

From: Alexei Starovoitov
Date: Fri Aug 21 2020 - 14:23:30 EST


On Fri, Aug 21, 2020 at 08:01:32AM -0700, Roman Gushchin wrote:
>
> diff --git a/tools/testing/selftests/bpf/progs/map_ptr_kern.c b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> index 473665cac67e..49d1dcaf7999 100644
> --- a/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> +++ b/tools/testing/selftests/bpf/progs/map_ptr_kern.c
> @@ -26,17 +26,12 @@ __u32 g_line = 0;
> return 0; \
> })
>
> -struct bpf_map_memory {
> - __u32 pages;
> -} __attribute__((preserve_access_index));
> -
> struct bpf_map {
> enum bpf_map_type map_type;
> __u32 key_size;
> __u32 value_size;
> __u32 max_entries;
> __u32 id;
> - struct bpf_map_memory memory;
> } __attribute__((preserve_access_index));

hmm. Did you build selftests?

progs/map_ptr_kern.c:45:14: error: no member named 'memory' in 'struct bpf_map'
VERIFY(map->memory.pages > 0);
~~~ ^
progs/map_ptr_kern.c:25:8: note: expanded from macro 'VERIFY'