Re: [PATCH 3/3] drm/bridge: ps8640: Rework power state handling

From: Sam Ravnborg
Date: Fri Aug 21 2020 - 07:39:20 EST


Hi Enric.

>
> Let me reformulate the question for if it was not clear.
>
> What I did is be able to read the EDID every time userspace asks for it (so
> kernel enables all the required) and Sam is proposing to just fail if all is not
> setup. I can obviously do this but my question is, at which point I should leave
> all the logic enabled to be able to read the EDID (after probe?, after
> pre_enable, after enable?) It is not clear for me from the API.

I am not clear if my suggestion is a good suggestion.

I recall I saw something similar in another bridge driver.

If no-one else chimes in then go ahead with your original approach
where there is less restriction when it is possible to read edid.

Sam