Re: [PATCH] thermal: sysfs: Fall back to vmalloc() for cooling device's statistics

[Yue Hu]

On Fri, 21 Aug 2020 08:39:45 +0000
David Laight <David.Laight@xxxxxxxxxx> wrote:

> From: Yue Hu
> > Sent: 21 August 2020 03:44
> > 
> > From: Yue Hu <huyue2@xxxxxxxxxx>
> > 
> > We observed warning about kzalloc() when register thermal cooling device
> > in backlight_device_register(). backlight display can be a cooling device
> > since reducing screen brightness will can help reduce temperature.
> > 
> > However, ->get_max_state of backlight will assign max brightness of 1024
> > to states. The memory size can be getting 1MB+ due to states * states.
> > That is so large to trigger kmalloc() warning.  
> 
> I can't help feeling that there is an 'adequate' implementation
> that doesn't require anywhere near 1MB of memory.

However, it should be a potential issue due to what i described above, rt?

Thx.

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>