Re: [PATCH] memory: brcmstb_dpfe: fix array index out of bounds

From: Florian Fainelli
Date: Thu Aug 20 2020 - 23:15:09 EST




On 8/20/2020 6:03 PM, Markus Mayer wrote:
We would overrun the error_text array if we hit a TIMEOUT condition,
because we were using the error code "ETIMEDOUT" (which is 110) as an
array index.

We fix the problem by correcting the array index and by providing a
function to retrieve error messages rather than accessing the array
directly. The function includes a bounds check that prevents the array
from being overrun.

Signed-off-by: Markus Mayer <mmayer@xxxxxxxxxxxx>

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Fixes: 2f330caff577 ("memory: brcmstb: Add driver for DPFE")
Reported-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

(Colin, was there a specific coverity ID you wanted to use?)
--
Florian