Re: [PATCH] hv_utils: drain the timesync packets on onchannelcallback

From: Vineeth Pillai
Date: Thu Aug 20 2020 - 17:48:22 EST



Hi Michael,

> > + pr_warn("TimeSync IC pkt recv failed (Err: %d)\n",
> > + ret);
>
> Let's use pr_warn_once().
>
> If there's a packet at the head of the ring buffer that specifies a bogus length,
> we could take the error path. But the bad packet stays at the head of the ring buffer,
> so if we end up back here again, we'll spit out the same error message. We
> actually should not end up here again because Hyper-V shouldn't interrupt
> when adding a packet to a non-empty ring buffer, but who knows what might
> happen.
>
Valid point, will fix this in the next iteration.

Thanks,
Vineeth