Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio

[Hui Wang]

On 2020/8/20 上午2:10, Kai-Heng Feng wrote:
> > On Aug 20, 2020, at 01:18, Takashi Iwai <tiwai@xxxxxxx> wrote:
> >
> > [ Adding a few more relevant people to Cc. ]
> >
> > On Wed, 19 Aug 2020 13:57:57 +0200,
> > penghao wrote:
> > > TI024Gen3 USB-audio is controlled by TI024Gen3,when TI024Gens
> > > enter sleep mode, USB-audio will disconnect from USB bus port,
> > > wakup form s3 state
> > >
> > > Signed-off-by: penghao <penghao@xxxxxxxxxxxxx>
> > > ---
> > > sound/usb/card.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/sound/usb/card.c b/sound/usb/card.c
> > > index 696e788c5d31..6bdbb34009b3 100644
> > > --- a/sound/usb/card.c
> > > +++ b/sound/usb/card.c
> > > @@ -658,6 +658,12 @@ static int usb_audio_probe(struct usb_interface *intf,
> > > 	}
> > >
> > > 	dev_set_drvdata(&dev->dev, chip);
> > > +	/*
> > > +	 *ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo
> > > +	 *ThinkCentre TI024Gen3 usb-audio
> > > +	 */
> > > +	if ((usb_id->idVendor == 0x17ef) && (usb_id->idProduct == 0xa012))
> > > +		device_set_wakeup_enable(＆dev->dev, 0);
> > Here it's no proper ASCII letter, and this must be broken.
> > Please check the actual patch before submitting.
> >
> > In anyway, before going further, I'd like to hear from other people
> > whether this is really mandatory and appropriate.  And whether it's
> > specific to that device, too (not other Lenovo devices?)
> If USB remote wakeup on this device is broken then we need to fix it in USB core instead of USB audio.
> We need USB and xHCI logs to understand the real problem here, the commit message doesn't contain enough information.
>
> Kai-Heng

I checked with our QA, we didn't enable this machine before.  And I 
tried 2 different usb audio cards, neither of them has wakeup 
capability. it is weird that your usb sound card (maybe a built-in usb 
sound card) has wakeup capability.

You could file a bug to 
https://bugs.launchpad.net/ubuntu/+source/linux/+filebug, then upload 
the needed logs,  Kai-Heng and I will help investigate this issue.

Thanks,

Hui.

> > thanks,
> >
> > Takashi