Re: [PATCH 1/2] mm/mmap: rename __vma_unlink_common() to __vma_unlink()

From: Andrew Morton
Date: Wed Aug 19 2020 - 16:12:16 EST


On Mon, 10 Aug 2020 07:20:56 +0800 Wei Yang <richard.weiyang@xxxxxxxxxxxxxxxxx> wrote:

> __vma_unlink_common() and __vma_unlink() are counterparts. Since there is

I assume you meant "__vma_link()" here?

> not function named __vma_unlink(), let's rename it to __vma_unlink() to
> make the code more self-explain and easy for audience to understand.
>
> Otherwise we may expect there are several variants of vma_unlink and
> __vma_unlink_common() is used by them.