Re: [PATCH v2 1/4] libnvdimm: Fix memory leaks in of_pmem.c

From: Oliver O'Halloran
Date: Wed Aug 19 2020 - 09:35:55 EST


On Wed, Aug 19, 2020 at 10:28 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:
>
> > The memory priv->bus_desc.provider_name allocated by kstrdup() is not
> > freed correctly.

Personally I thought his commit message was perfectly fine. A little
unorthodox, but it works.

> How do you think about to choose an imperative wording for
> a corresponding change description?

...but this! This is word salad.

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151
>
> Regards,
> Markus