Re: [PATCH][next] selinux: fix allocation failure check on newpolicy->sidtab

From: Paul Moore
Date: Wed Aug 19 2020 - 09:21:06 EST


On Wed, Aug 19, 2020 at 6:42 AM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The allocation check of newpolicy->sidtab is null checking if
> newpolicy is null and not newpolicy->sidtab. Fix this.
>
> Addresses-Coverity: ("Logically dead code")
> Fixes: c7c556f1e81b ("selinux: refactor changing booleans")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> security/selinux/ss/services.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Colin, merged into selinux/next.

--
paul moore
www.paul-moore.com