Re: [PATCH v6 08/10] net: eth: altera: add support for ptp and timestamping

[Jakub Kicinski]

On Tue, 18 Aug 2020 23:46:11 +0800 Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@xxxxxxxxx>
> 
> Add support for the ptp clock used with the tse, and update
> the driver to support timestamping when enabled.  We also
> enable debugfs entries for the ptp clock to allow some user
> control and interaction with the ptp clock.
> 
> Cc: Richard Cochran <richardcochran@xxxxxxxxx>
> Signed-off-by: Dalon Westergreen <dalon.westergreen@xxxxxxxxx>
> Signed-off-by: Joyce Ooi <joyce.ooi@xxxxxxxxx>

Please address the W=1 warning:

drivers/net/ethernet/altera/intel_fpga_tod.c:293:55: warning: Using plain integer as NULL pointer