Re: [PATCH] clang-format: Fix: Maximum line length is now 100

From: Alex Dewar
Date: Tue Aug 18 2020 - 12:54:10 EST


On Tue, Aug 18, 2020 at 09:52:20AM -0700, Joe Perches wrote:
> On Tue, 2020-08-18 at 17:24 +0100, Alex Dewar wrote:
> > Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> > warning") the kernel style is now for lines to be a maximum of 100 rather
> > than 80 columns. Update .clang-format accordingly.
> []
> > diff --git a/.clang-format b/.clang-format
> []
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> > #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> > BreakAfterJavaFieldAnnotations: false
> > BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
>
> No thank you.
>
> 100 is used for exceptional line length, not
> for reformatting all lines up to 100 chars.
>
> See the previous discussion about the same patch
> submitted earlier in June:
>
> https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@xxxxxxxxxx/
>
>

Ahh, my mistake. Thanks for getting back to me anyhoo.

Alex