Re: [RFC][PATCH v2 08/10] smp,irq_work: Use the new irq_work API

From: Christoph Hellwig
Date: Tue Aug 18 2020 - 12:26:10 EST


On Tue, Aug 18, 2020 at 12:51:10PM +0200, Peter Zijlstra wrote:
> Convert the performance sensitive users of
> smp_call_single_function_async() over to the new
> irq_work_queue_remote_static().
>
> The new API is marginally less crap but taking these users away allows
> fixing up smp_call_single_function_async() without risk of performance
> regressions.

You probably want a conversion patch per subsystem so that it sticks
out. What is so crap about this API? How could we as subsystem
maintainers help to make it less crappy?