RE: [PATCH v2] ASoC: hdac_hdmi: support 'ELD' mixer

From: Lu, Brent
Date: Tue Aug 18 2020 - 10:49:57 EST


>
> This is a bit iffy part. If same PCM is connected to multiple receivers, you
> return ELD data for the first one and ignore the rest. OTOH, this is inline with
> comment in hdac_hdmi_get_port_from_cvt() in that this pcm-to-many
> routing is not really supported by the driver now. But jack status reporting is
> done a port basis, not per PCM/CVTs, so this is not fully aligned.
>
> Hmm. Given the proposed patch is aligned with the user-space interface
> exposed by patch_hdmi.c, I'm ok to go with this. Can you add an explicit
> comment to explain what is happening above?
>
> Br, Kai

Fix it in v3. Thank you for the review.


Regards,
Brent