Re: [PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink

From: Greg Kroah-Hartman
Date: Tue Aug 18 2020 - 10:09:49 EST

Next message: Greg Kroah-Hartman: "Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON"
Previous message: Thierry Reding: "Re: [PATCH] PCI: tegra: no need to check return value of debugfs_create functions"
In reply to: Tomer Samara: "[PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink"
Next in thread: Tomer Samara: "[PATCH v2 3/4] staging: android: Convert BUG to WARN"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, Aug 16, 2020 at 10:24:22PM +0300, Tomer Samara wrote:
> Add error check to ion_page_pool_shrink after calling
> ion_page_pool_remove, due to converting BUG_ON to WARN_ON.
>
> Signed-off-by: Tomer Samara <tomersamara98@xxxxxxxxx>

So this fixes a previous patch? That's not good, please merge them
together so you do not cause a bug and then fix it up later on.

thanks,

greg k-h

Next message: Greg Kroah-Hartman: "Re: [PATCH v2 1/4] staging: android: Replace BUG_ON with WARN_ON"
Previous message: Thierry Reding: "Re: [PATCH] PCI: tegra: no need to check return value of debugfs_create functions"
In reply to: Tomer Samara: "[PATCH v2 2/4] staging: android: Add error handling to ion_page_pool_shrink"
Next in thread: Tomer Samara: "[PATCH v2 3/4] staging: android: Convert BUG to WARN"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]