Re: [PATCH] uart:8250: change lock order in serial8250_do_startup()

From: Andy Shevchenko
Date: Tue Aug 18 2020 - 09:14:31 EST


On Tue, Aug 18, 2020 at 02:52:18PM +0200, Petr Mladek wrote:
> On Fri 2020-08-14 12:59:28, Andy Shevchenko wrote:
> > On Fri, Aug 14, 2020 at 10:38:02AM +0900, Sergey Senozhatsky wrote:
> > > We have a number of "uart.port->desc.lock vs desc.lock->uart.port"
> > > lockdep reports coming from 8250 driver; this causes a bit of trouble
> > > to people, so let's fix it.
> >
> > I guess we may add some tags here
> >
> > Fixes: 768aec0b5bcc ("serial: 8250: fix shared interrupts issues with SMP and RT kernels")
> > Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > Reported-by: Raul Rangel <rrangel@xxxxxxxxxx>
> > BugLink: https://bugs.chromium.org/p/chromium/issues/detail?id=1114800
> > Link: https://lore.kernel.org/lkml/CAHQZ30BnfX+gxjPm1DUd5psOTqbyDh4EJE=2=VAMW_VDafctkA@xxxxxxxxxxxxxx/T/#u
>
> "Link:" tag should point to the mail that is applied using git am.
> I am not sure if there is a tag for related discussion in another
> mail threads.

It's fine to have several Link tags and in the past we have them for bug
reports thru mailing lists or so.

> Andy proposed many changes. Sergey, could you please send v2?

There is a v2.

https://lore.kernel.org/linux-serial/20200817022646.1484638-1-sergey.senozhatsky@xxxxxxxxx/T/#u

--
With Best Regards,
Andy Shevchenko