Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

From: Murali Karicheri
Date: Mon Aug 17 2020 - 16:59:22 EST




On 8/16/20 6:46 PM, Stephen Hemminger wrote:
On Thu, 6 Aug 2020 16:37:11 -0400
Murali Karicheri <m-karicheri2@xxxxxx> wrote:

+

+ print_int(PRINT_ANY,
+ "proto",
+ "proto %d ",
+ rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));

Since this unsigned value, you probably want to use print_uint, or print_hhu.
Also please put as many arguments on one line that will fit in 80 (to 90) characters.

if (tb[IFLA_HSR_PROTOCOL])
print_hhu(PRINT_ANY, "proto", "proto %hhu ",
rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));

Ok. Will send v5 shortly for this.
--
Murali Karicheri
Texas Instruments