Re: [PATCH v3 0/3] block: use generic power management

From: Vaibhav Gupta
Date: Mon Aug 17 2020 - 03:57:45 EST


On Wed, Jul 22, 2020 at 02:03:32PM +0530, Vaibhav Gupta wrote:
> Linux Kernel Mentee: Remove Legacy Power Management.
>
> The purpose of this patch series is to upgrade power management in block
> drivers. This has been done by upgrading .suspend() and .resume() callbacks.
>
> The upgrade makes sure that the involvement of PCI Core does not change the
> order of operations executed in a driver. Thus, does not change its behavior.
>
> In general, drivers with legacy PM, .suspend() and .resume() make use of PCI
> helper functions like pci_enable/disable_device_mem(), pci_set_power_state(),
> pci_save/restore_state(), pci_enable/disable_device(), etc. to complete
> their job.
>
> The conversion requires the removal of those function calls, change the
> callbacks' definition accordingly and make use of dev_pm_ops structure.
>
> All patches are compile-tested only.
>
> Test tools:
> - Compiler: gcc (GCC) 10.1.0
> - allmodconfig build: make -j$(nproc) W=1 all
>
> v3: v2 needed some changes in commit messages.
>
> Vaibhav Gupta (3):
> mtip32xx: use generic power management
> rsxx: use generic power management
> skd: use generic power management
>
> drivers/block/mtip32xx/mtip32xx.c | 54 +++++++------------------------
> drivers/block/rsxx/core.c | 9 ++++--
> drivers/block/skd_main.c | 30 +++++------------
> 3 files changed, 27 insertions(+), 66 deletions(-)
>
> --
> 2.27.0
>