Re: [PATCH] mm/migrate: fix migrate_pgmap_owner w/o CONFIG_MMU_NOTIFIER

From: Jason Gunthorpe
Date: Thu Aug 06 2020 - 19:44:38 EST


On Thu, Aug 06, 2020 at 04:39:58PM -0700, Randy Dunlap wrote:
> On 8/6/20 12:33 PM, Ralph Campbell wrote:
> > On x86_64, when CONFIG_MMU_NOTIFIER is not set/enabled, there is a
> > compiler error:
> >
> > ../mm/migrate.c: In function 'migrate_vma_collect':
> > ../mm/migrate.c:2481:7: error: 'struct mmu_notifier_range' has no member
> > named 'migrate_pgmap_owner'
> > range.migrate_pgmap_owner = migrate->pgmap_owner;
> > ^
> >
> > Fixes: 998427b3ad2c ("mm/notifier: add migration invalidation type")
> > Signed-off-by: Ralph Campbell <rcampbell@xxxxxxxxxx>
> > Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> Acked-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> # build-tested

Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>

I thought it spent enough time in linux-next and for 0-day to catch
things like this, but I guess I was wrong.

Linus has already merged the hmm pull request.

Andrew Morton: Can you pick this fix up to forward to Linus?

Thanks,
Jason