Re: [PATCH] hwmon: axi-fan-control: remove duplicate macros

From: Guenter Roeck
Date: Tue Aug 04 2020 - 17:27:43 EST


On Mon, Aug 03, 2020 at 08:43:11AM +0300, Alexandru Ardelean wrote:
> These macros are also present in the "include/linux/fpga/adi-axi-common.h"
> file which is included in this driver.
>
> This patch removes them from the AXI Fan Control driver. No sense in having
> them in 2 places.
>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@xxxxxxxxxx>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/axi-fan-control.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/hwmon/axi-fan-control.c b/drivers/hwmon/axi-fan-control.c
> index 38d9cdb3db1a..e3f6b03e6764 100644
> --- a/drivers/hwmon/axi-fan-control.c
> +++ b/drivers/hwmon/axi-fan-control.c
> @@ -15,10 +15,6 @@
> #include <linux/of.h>
> #include <linux/platform_device.h>
>
> -#define ADI_AXI_PCORE_VER_MAJOR(version) (((version) >> 16) & 0xff)
> -#define ADI_AXI_PCORE_VER_MINOR(version) (((version) >> 8) & 0xff)
> -#define ADI_AXI_PCORE_VER_PATCH(version) ((version) & 0xff)
> -
> /* register map */
> #define ADI_REG_RSTN 0x0080
> #define ADI_REG_PWM_WIDTH 0x0084