Re: [PATCH v2 09/24] virtio_fs: correct tags for config space fields

From: Vivek Goyal
Date: Tue Aug 04 2020 - 09:36:42 EST


On Mon, Aug 03, 2020 at 04:59:13PM -0400, Michael S. Tsirkin wrote:
> Since fs is a modern-only device,
> tag config space fields as having little endian-ness.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

virtio spec does list this field as "le32".

Acked-by: Vivek Goyal <vgoyal@xxxxxxxxxx>

Vivek

> ---
> include/uapi/linux/virtio_fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/virtio_fs.h b/include/uapi/linux/virtio_fs.h
> index b02eb2ac3d99..3056b6e9f8ce 100644
> --- a/include/uapi/linux/virtio_fs.h
> +++ b/include/uapi/linux/virtio_fs.h
> @@ -13,7 +13,7 @@ struct virtio_fs_config {
> __u8 tag[36];
>
> /* Number of request queues */
> - __u32 num_request_queues;
> + __le32 num_request_queues;
> } __attribute__((packed));
>
> #endif /* _UAPI_LINUX_VIRTIO_FS_H */
> --
> MST
>