Re: [PATCH v2 12/24] virtio_iommu: correct tags for config space fields

From: Jean-Philippe Brucker
Date: Tue Aug 04 2020 - 04:00:51 EST


On Mon, Aug 03, 2020 at 04:59:27PM -0400, Michael S. Tsirkin wrote:
> Since this is a modern-only device,
> tag config space fields as having little endian-ness.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

Reviewed-by: Jean-Philippe Brucker <jean-philippe@xxxxxxxxxx>

And tested with the latest sparse

> ---
> include/uapi/linux/virtio_iommu.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/uapi/linux/virtio_iommu.h b/include/uapi/linux/virtio_iommu.h
> index 48e3c29223b5..237e36a280cb 100644
> --- a/include/uapi/linux/virtio_iommu.h
> +++ b/include/uapi/linux/virtio_iommu.h
> @@ -18,24 +18,24 @@
> #define VIRTIO_IOMMU_F_MMIO 5
>
> struct virtio_iommu_range_64 {
> - __u64 start;
> - __u64 end;
> + __le64 start;
> + __le64 end;
> };
>
> struct virtio_iommu_range_32 {
> - __u32 start;
> - __u32 end;
> + __le32 start;
> + __le32 end;
> };
>
> struct virtio_iommu_config {
> /* Supported page sizes */
> - __u64 page_size_mask;
> + __le64 page_size_mask;
> /* Supported IOVA range */
> struct virtio_iommu_range_64 input_range;
> /* Max domain ID size */
> struct virtio_iommu_range_32 domain_range;
> /* Probe buffer size */
> - __u32 probe_size;
> + __le32 probe_size;
> };
>
> /* Request types */
> --
> MST
>