Re: [PATCH v2 01/24] virtio_balloon: fix sparse warning

[David Hildenbrand]

> Am 03.08.2020 um 22:58 schrieb Michael S. Tsirkin <mst@xxxxxxxxxx>:
> 
> balloon uses virtio32_to_cpu instead of cpu_to_virtio32
> to convert a native endian number to virtio.
> No practical difference but makes sparse warn.
> Fix it up.
> 
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

I think I acked this one already.

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

> ---
> drivers/virtio/virtio_balloon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
> index 54fd989f9353..8bc1704ffdf3 100644
> --- a/drivers/virtio/virtio_balloon.c
> +++ b/drivers/virtio/virtio_balloon.c
> @@ -600,7 +600,7 @@ static int send_cmd_id_start(struct virtio_balloon *vb)
>    while (virtqueue_get_buf(vq, &unused))
>        ;
> 
> -    vb->cmd_id_active = virtio32_to_cpu(vb->vdev,
> +    vb->cmd_id_active = cpu_to_virtio32(vb->vdev,
>                    virtio_balloon_cmd_id_received(vb));
>    sg_init_one(&sg, &vb->cmd_id_active, sizeof(vb->cmd_id_active));
>    err = virtqueue_add_outbuf(vq, &sg, 1, &vb->cmd_id_active, GFP_KERNEL);
> -- 
> MST
>