Re: [PATCH] gve: Fix the size used in a 'dma_free_coherent()' call

[Christophe JAILLET]

Le 03/08/2020 à 21:35, Joe Perches a écrit :
> On Mon, 2020-08-03 at 21:19 +0200, Christophe JAILLET wrote:
> > Le 03/08/2020 à 17:41, Jakub Kicinski a écrit :
> > > On Sun,  2 Aug 2020 16:15:23 +0200 Christophe JAILLET wrote:
> > > > Update the size used in 'dma_free_coherent()' in order to match the one
> > > > used in the corresponding 'dma_alloc_coherent()'.
> > > >
> > > > Fixes: 893ce44df5 ("gve: Add basic driver framework for Compute Engine Virtual NIC")
> > > > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> > >
> > > Fixes tag: Fixes: 893ce44df5 ("gve: Add basic driver framework for Compute Engine Virtual NIC")
> > > Has these problem(s):
> > > 	- SHA1 should be at least 12 digits long
> > > 	  Can be fixed by setting core.abbrev to 12 (or more) or (for git v2.11
> > > 	  or later) just making sure it is not set (or set to "auto").
> >
> > Hi,
> >
> > I have git 2.25.1 and core.abbrev is already 12, both in my global
> > .gitconfig and in the specific .git/gitconfig of my repo.
> >
> > I would have expected checkpatch to catch this kind of small issue.
> > Unless I do something wrong, it doesn't.
> >
> > Joe, does it make sense to you and would one of the following patch help?
>
> 18 months ago I sent:
>
> https://lore.kernel.org/lkml/40bfc40958fca6e2cc9b86101153aa0715fac4f7.camel@xxxxxxxxxxx/

Looks like the same spirit.
I've not tested, but doesn't the:
   ($line =~ /(?:\s|^)[0-9a-f]{12,40}(?:[\s"'\(\[]|$)/i &&
at the top short cut the rest of the regex?

I read it as "the line should have something that looks like a commit id 
of 12+ char to process further".

So smaller commit id would not be checked.
Did I miss something?


Basically, my proposal is to replace this 12 by a 5 in order to accept 
smaller strings before checking if it looks well formatted or not.

CJ