Re: [PATCH v7 09/10] media: tegra-video: Add CSI MIPI pads calibration

From: Dmitry Osipenko
Date: Fri Jul 31 2020 - 21:04:45 EST


01.08.2020 00:32, Sowjanya Komatineni ÐÐÑÐÑ:
> CSI MIPI pads need to be enabled and calibrated for capturing from
> the external sensor or transmitter.
>
> MIPI CAL unit calibrates MIPI pads pull-up, pull-down and termination
> impedances. Calibration is done by co-work of MIPI BIAS pad and MIPI
> CAL control unit.
>
> Triggering calibration start can happen any time after MIPI pads are
> enabled but calibration results will be latched and applied to MIPI
> pads by MIPI CAL unit only when the link is in LP11 state and then
> calibration status register gets updated.
>
> This patch enables CSI MIPI pads and calibrates them during streaming.
>
> Tegra CSI receiver is able to catch the very first clock transition.
> So, CSI receiver is always enabled prior to sensor streaming and
> trigger of calibration start is done during CSI subdev streaming and
> status of calibration is verified after sensor stream on.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> ---
> drivers/staging/media/tegra-video/TODO | 1 -
> drivers/staging/media/tegra-video/csi.c | 61 +++++++++++++++++++++++++++++++--
> drivers/staging/media/tegra-video/csi.h | 2 ++
> drivers/staging/media/tegra-video/vi.c | 28 ++++++++++++---
> 4 files changed, 84 insertions(+), 8 deletions(-)

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>