Re: [PATCH net-next] tun: add missing rcu annotation in tun_set_ebpf()

From: David Miller
Date: Fri Jul 31 2020 - 20:18:20 EST


From: Jason Wang <jasowang@xxxxxxxxxx>
Date: Fri, 31 Jul 2020 00:17:20 -0400

> We expecte prog_p to be protected by rcu, so adding the rcu annotation
> to fix the following sparse warning:
>
> drivers/net/tun.c:3003:36: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3003:36: expected struct tun_prog [noderef] __rcu **prog_p
> drivers/net/tun.c:3003:36: got struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3292:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3292:42: got struct tun_prog [noderef] __rcu **
> drivers/net/tun.c:3296:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/net/tun.c:3296:42: expected struct tun_prog **prog_p
> drivers/net/tun.c:3296:42: got struct tun_prog [noderef] __rcu **
>
> Reported-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Signed-off-by: Jason Wang <jasowang@xxxxxxxxxx>

Applied, thanks.