Re: [PATCH 8/8] modules: inherit TAINT_PROPRIETARY_MODULE

[Jessica Yu]

+++ Christoph Hellwig [31/07/20 11:00 +0200]:
> On Fri, Jul 31, 2020 at 10:51:30AM +0200, Jessica Yu wrote:
> > > +	if (mod->using_gplonly_symbols) {
> > > +		pr_info("%s: module using GPL-only symbols uses symbols from proprietary module %s.\n",
> > > +			mod->name, owner->name);
> >
> > pr_err() maybe?
> >
> > > +		return false;
> > > +	}
> > > +
> > > +	if (!test_bit(TAINT_PROPRIETARY_MODULE, &mod->taints)) {
> > > +		pr_info("%s: module uses symbols from proprietary module %s, inheriting taint.\n",
> > > +			mod->name, owner->name);
> >
> > and pr_warn()? But otherwise this looks much better.
>
> Ok with me.  Can you just fix it up, or do you want a full resend?

I can fix it up, no need to resend. Thanks!