Re: [PATCH drm/hisilicon 1/2] drm/hisilicon: Remove the unnecessary header files

[Thomas Zimmermann]

Hi,

Am 31.07.20 um 03:05 schrieb Tian Tao:
> Remove some unused header files.

maybe say that you're removing the include statements. Because you're
not removing the actual header files. :)

Best regards
Thomas

> 
> Signed-off-by: Tian Tao <tiantao6@xxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c   | 3 ---
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c  | 5 -----
>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 2 --
>  3 files changed, 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> index cc70e83..66132eb 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c
> @@ -17,9 +17,6 @@
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_fourcc.h>
>  #include <drm/drm_gem_vram_helper.h>
> -#include <drm/drm_plane_helper.h>
> -#include <drm/drm_print.h>
> -#include <drm/drm_probe_helper.h>
>  #include <drm/drm_vblank.h>
>  
>  #include "hibmc_drm_drv.h"
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> index b8d839a..54f6144 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
> @@ -11,18 +11,13 @@
>   *	Jianhua Li <lijianhua@xxxxxxxxxx>
>   */
>  
> -#include <linux/console.h>
> -#include <linux/module.h>
>  #include <linux/pci.h>
>  
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_drv.h>
> -#include <drm/drm_fb_helper.h>
>  #include <drm/drm_gem_vram_helper.h>
>  #include <drm/drm_irq.h>
>  #include <drm/drm_managed.h>
> -#include <drm/drm_print.h>
> -#include <drm/drm_probe_helper.h>
>  #include <drm/drm_vblank.h>
>  
>  #include "hibmc_drm_drv.h"
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> index 2ca69c3..ed12f61 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c
> @@ -11,10 +11,8 @@
>   *	Jianhua Li <lijianhua@xxxxxxxxxx>
>   */
>  
> -#include <drm/drm_gem_vram_helper.h>
>  #include <drm/drm_atomic_helper.h>
>  #include <drm/drm_probe_helper.h>
> -#include <drm/drm_crtc_helper.h>
>  #include <drm/drm_print.h>
>  
>  #include "hibmc_drm_drv.h"
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 NÃrnberg, Germany
(HRB 36809, AG NÃrnberg)
GeschÃftsfÃhrer: Felix ImendÃrffer

Attachment: signature.asc
Description: OpenPGP digital signature