Re: [PATCH -next] sched/uclamp: kill unnecessary mutex_init()

[Steven Rostedt]

On Sat, 25 Jul 2020 16:56:29 +0800
Qinglang Miao <miaoqinglang@xxxxxxxxxx> wrote:

> The mutex uclamp_mutex is initialized statically. It is
> unnecessary to initialize by mutex_init().
> 

Seems reasonable.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve

> Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> ---
>  kernel/sched/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 29d557c1f..9a8b7ed3a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1331,8 +1331,6 @@ static void __init init_uclamp(void)
>  	enum uclamp_id clamp_id;
>  	int cpu;
>  
> -	mutex_init(&uclamp_mutex);
> -
>  	for_each_possible_cpu(cpu)
>  		init_uclamp_rq(cpu_rq(cpu));
>