Re: [PATCH] sched: remove duplicated tick_nohz_full_enabled() check

[Steven Rostedt]

On Tue, 28 Jul 2020 19:17:55 +0800
linmiaohe <linmiaohe@xxxxxxxxxx> wrote:

> From: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> 
> The func tick_nohz_full_enabled() is also called by tick_nohz_full_cpu().
> So this one is duplicated and should be removed.

Seems reasonable.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

-- Steve

> 
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
> ---
>  kernel/sched/sched.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> index 877fb08eb1b0..02028f785f87 100644
> --- a/kernel/sched/sched.h
> +++ b/kernel/sched/sched.h
> @@ -1930,12 +1930,7 @@ extern int __init sched_tick_offload_init(void);
>   */
>  static inline void sched_update_tick_dependency(struct rq *rq)
>  {
> -	int cpu;
> -
> -	if (!tick_nohz_full_enabled())
> -		return;
> -
> -	cpu = cpu_of(rq);
> +	int cpu = cpu_of(rq);
>  
>  	if (!tick_nohz_full_cpu(cpu))
>  		return;