Re: [PATCH v18 3/3] Input: new da7280 haptic driver

From: Andy Shevchenko
Date: Thu Jul 30 2020 - 04:31:07 EST


On Thu, Jul 30, 2020 at 08:16:31AM +0200, Uwe Kleine-König wrote:
> On Wed, Jul 29, 2020 at 10:06:53PM -0700, Dmitry Torokhov wrote:
> > On Wed, Jul 29, 2020 at 09:21:45AM +0200, Uwe Kleine-König wrote:
> > > On Tue, Jul 28, 2020 at 11:36:38PM -0700, Dmitry Torokhov wrote:

...

> > Maybe we should introduce something like '%de' for the integer error
> > case?
>
> I suggested that some time ago with limited success, see
> https://lore.kernel.org/lkml/20200129115516.zsvxu56e6h7gheiw@xxxxxxxxxxxxxxx/

Oh, please, no need for that really. We have now dev_err_probe() on its way to
upstream (now in Greg's tree) which hides all this behind.

Just switch to dev_err_probe() and forget about what is under the hood.

--
With Best Regards,
Andy Shevchenko