Re: [PATCH V8 1/6] clk: imx6sl: Use BIT(x) to avoid shifting signed 32-bit value by 31 bits

From: Arnd Bergmann
Date: Thu Jul 30 2020 - 03:23:06 EST


On Thu, Jul 30, 2020 at 2:03 AM Anson Huang <Anson.Huang@xxxxxxx> wrote:
>
> Use readl_relaxed() instead of __raw_readl(), and use BIT(x)
> instead of (1 << X) to fix below build warning reported by kernel
> test robot:
>
> drivers/clk/imx/clk-imx6sl.c:149:49: warning: Shifting signed 32-bit
> value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
> while (!(__raw_readl(anatop_base + PLL_ARM) & BM_PLL_ARM_LOCK))
>
> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>