Re: [PATCH v4 06/17] fs/kernel_read_file: Remove redundant size argument

From: James Morris
Date: Wed Jul 29 2020 - 22:25:16 EST


On Wed, 29 Jul 2020, Kees Cook wrote:

> In preparation for refactoring kernel_read_file*(), remove the redundant
> "size" argument which is not needed: it can be included in the return
> code, with callers adjusted. (VFS reads already cannot be larger than
> INT_MAX.)
>
> Acked-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>
> Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

Reviewed-by: James Morris <jamorris@xxxxxxxxxxxxxxxxxxx>

--
James Morris
<jmorris@xxxxxxxxx>