Re: [PATCH 15/23] seq_file: switch over direct seq_read method calls to seq_read_iter

From: Al Viro
Date: Wed Jul 29 2020 - 16:59:30 EST


On Fri, Jul 17, 2020 at 11:09:13PM +0200, Thomas Gleixner wrote:
>
> Needs some thought and maybe some cocci help from Julia, but that's way
> better than this brute force sed thing which results in malformed crap
> like this:
>
> static const struct file_operations debug_stats_fops = {
> .open = debug_stats_open,
> .read_iter = seq_read_iter,
> .llseek = seq_lseek,
> .release = single_release,
> };
>
> and proliferates the copy and paste voodoo programming.

Better copy and paste than templates, IMO; at least the former is
greppable; fucking DEFINE_..._ATRIBUTE is *NOT*, especially due
to the use of ##.