Re: [PATCH v1 2/6] mm/page_isolation: don't dump_page(NULL) in set_migratetype_isolate()

From: David Hildenbrand
Date: Wed Jul 29 2020 - 14:41:42 EST




> Am 29.07.2020 um 20:36 schrieb Mike Kravetz <mike.kravetz@xxxxxxxxxx>:
>
> ïOn 7/29/20 11:08 AM, David Hildenbrand wrote:
>> I have no clue what you mean with "reintroducing this abandoning of
>> pageblocks". All this patch is changing is not doing the dump_page() -
>> or am I missing something important?
>
> My apologies!!!
>

No worries, thanks for reviewing!!

> I got confused when I saw 'Return -EBUSY' removed from the comment and
> assumed the code would not return an error code. The code now more
> explicitly does return -EBUSY. My concern was when I incorrectly thought
> you were removing the error return code. Sorry for the noise.
>
> Acked-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> --
> Mike Kravetz
>