Re: [PATCH net-next RFC 09/13] devlink: Add enable_remote_dev_reset generic parameter

From: Moshe Shemesh
Date: Wed Jul 29 2020 - 10:42:43 EST



On 7/28/2020 3:59 AM, Jakub Kicinski wrote:
On Mon, 27 Jul 2020 14:02:29 +0300 Moshe Shemesh wrote:
The enable_remote_dev_reset devlink param flags that the host admin
allows device resets that can be initiated by other hosts. This
parameter is useful for setups where a device is shared by different
hosts, such as multi-host setup. Once the user set this parameter to
false, the driver should NACK any attempt to reset the device while the
driver is loaded.

Signed-off-by: Moshe Shemesh <moshe@xxxxxxxxxxxx>
There needs to be a devlink event generated when reset is triggered
(remotely or not).

You're also missing failure reasons. Users need to know if the reset
request was clearly nacked by some host, not supported, etc. vs
unexpected failure.


I will fix and send extack message to the user accordingly.