Re: mmotm 2020-07-27-18-18 uploaded (mm/page_alloc.c)

From: Michael S. Tsirkin
Date: Wed Jul 29 2020 - 10:18:43 EST


On Tue, Jul 28, 2020 at 03:31:43PM -0700, Andrew Morton wrote:
> On Wed, 29 Jul 2020 08:20:53 +1000 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
>
> > Hi Andrew,
> >
> > On Tue, 28 Jul 2020 14:55:53 -0700 Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > > config CONTIG_ALLOC
> > > def_bool (MEMORY_ISOLATION && COMPACTION) || CMA
> > >
> > > says this is an improper combination. And `make oldconfig' fixes it up.
> > >
> > > What's happening here?
> >
> > CONFIG_VIRTIO_MEM selects CONFIG_CONTIG_ALLOC ...
>
> Argh, select strikes again.
>
> So I guess VIRTIO_MEM should also select COMPACTION?

+Cc the maintainer.

--
MST