Re: [PATCH] net: nixge: fix potential memory leak in nixge_probe()

From: Markus Elfring
Date: Wed Jul 29 2020 - 03:50:41 EST

Next message: Matthias Brugger: "Re: [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc"
Previous message: Ankit Baluni: "[PATCH v3] Staging: media: atomisp: fixed a brace coding sytle issue"
In reply to: David Miller: "Re: [PATCH] net: nixge: fix potential memory leak in nixge_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> If some processes in nixge_probe() fail, free_netdev(dev)
> needs to be called to aviod a memory leak.

* Would you like to avoid a typo in this change description?

* An imperative wording can be preferred here, can't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=6ba1b005ffc388c2aeaddae20da29e4810dea298#n151

Regards,
Markus

Next message: Matthias Brugger: "Re: [PATCH 1/2] soc: mediatek: mtk-infracfg: Fix kerneldoc"
Previous message: Ankit Baluni: "[PATCH v3] Staging: media: atomisp: fixed a brace coding sytle issue"
In reply to: David Miller: "Re: [PATCH] net: nixge: fix potential memory leak in nixge_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]