Re: [net-next v4 3/6] net: marvell: prestera: Add basic devlink support

[Andy Shevchenko]

On Tue, Jul 28, 2020 at 3:30 PM Vadym Kochan <vadym.kochan@xxxxxxxxxxx> wrote:
> On Mon, Jul 27, 2020 at 04:07:07PM +0300, Andy Shevchenko wrote:
> > On Mon, Jul 27, 2020 at 3:23 PM Vadym Kochan <vadym.kochan@xxxxxxxxxxx> wrote:

...

> > > +       err = devlink_register(dl, sw->dev->dev);
> > > +       if (err) {
> > > +               dev_warn(sw->dev->dev, "devlink_register failed: %d\n", err);
> > > +               return err;
> > > +       }
> > > +
> > > +       return 0;
> >
> >   if (err)
> >     dev_warn(...);
> >
> >   return err;
> Would not it better to have 'return 0' at the end to visually indicate
> the success point ?

Up to you. Actually just noticed that you are using dev_warn() for
error. It should be dev_err().

-- 
With Best Regards,
Andy Shevchenko