Re: [PATCH v17 03/21] mm/compaction: correct the comments of compact_defer_shift

From: Alex Shi
Date: Tue Jul 28 2020 - 07:59:52 EST



>> * Compaction is deferred when compaction fails to result in a page
>> - * allocation success. 1 << compact_defer_limit compactions are skipped up
>> + * allocation success. compact_defer_shift++, compactions are skipped up
>> * to a limit of 1 << COMPACT_MAX_DEFER_SHIFT
>> */
>> void defer_compaction(struct zone *zone, int order)
>
> So this doesn't read right. I wouldn't keep the "++," in the
> explanation, and if we are going to refer to a limit of "1 <<
> COMPACT_MAX_DEFER_SHIFT" then maybe this should be left as "1 <<
> compact_defer_shift".
>

Thanks for comments! So is the changed patch fine?
--