Re: [PATCH 2/2] MIPS: Remove legacy MIPS_MACHINE option

From: Thomas Bogendoerfer
Date: Tue Jul 28 2020 - 04:39:04 EST


On Sun, Jul 26, 2020 at 06:58:28PM +0200, Paul Cercueil wrote:
> The CONFIG_MIPS_MACHINE option is dead code that hasn't been used in
> years. The Kconfig option is not selected anywhere, and the
> <asm/mips_machine.h> is not included anywhere either.
>
> To make things worse, for years it co-existed with a separate MIPS
> machine implementation as <asm/machine.h>. The two defined the
> 'mips_machine' structure with different fields, and the 'MIPS_MACHINE'
> macro with different parameters. The two used the same memory area
> (defined by the linker script) to store data, and you could totally use
> the two at the same time for all kinds of funny results.
>
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
> arch/mips/Kconfig | 3 --
> arch/mips/include/asm/mips_machine.h | 46 ---------------------
> arch/mips/kernel/Makefile | 1 -
> arch/mips/kernel/mips_machine.c | 62 ----------------------------
> 4 files changed, 112 deletions(-)
> delete mode 100644 arch/mips/include/asm/mips_machine.h
> delete mode 100644 arch/mips/kernel/mips_machine.c

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]