Re: [PATCH v4 3/3] usb: dwc2: don't use ID/Vbus detection if usb-role-switch on STM32MP15 SoCs

[Amelie DELAUNAY]

Hi,

On 7/27/20 9:44 PM, Andy Shevchenko wrote:
> On Mon, Jul 27, 2020 at 10:04 PM Martin Blumenstingl
> <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
> > On Mon, Jul 27, 2020 at 11:23 AM Amelie Delaunay <amelie.delaunay@xxxxxx> wrote:
>
> > > -ÂÂÂÂÂÂ p->activate_stm_id_vb_detection = true;
> > > +ÂÂÂÂÂÂ p->activate_stm_id_vb_detection =
> > > +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ !of_property_read_bool(np, "usb-role-switch");
> > the rest of params.c uses device_property_read_* instead of of_read_property_*
> > I thought I'd mention it so you can decide yourself whether this is
> > fine or needs to be changed
>
> Better to change and leave all on one line.

Thank you both for your review. I'll change it in upcoming v5. I'm still 
not used to exceed the 80 columns :)

Regards,
Amelie

> --
> With Best Regards,
> Andy Shevchenko