Re: [PATCH bpf-next v2 32/35] bpf: selftests: delete bpf_rlimit.h

[Song Liu]

> On Jul 27, 2020, at 11:06 PM, Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> wrote:
> 
> On Mon, Jul 27, 2020 at 12:25 PM Roman Gushchin <guro@xxxxxx> wrote:
>> 
>> As rlimit-based memory accounting is not used by bpf anymore,
>> there are no more reasons to play with memlock rlimit.
>> 
>> Delete bpf_rlimit.h which contained a code to bump the limit.
>> 
>> Signed-off-by: Roman Gushchin <guro@xxxxxx>
>> ---
> 
> We run test_progs on old kernels as part of libbpf Github CI. We'll
> need to either leave setrlimit() or do it conditionally, depending on
> detected kernel feature support.

Hmm... I am surprised that running test_progs on old kernels is not 
too noisy. Have we got any issue with that?

Thanks,
Song

> 
>> samples/bpf/hbm.c                             |  1 -
>> tools/testing/selftests/bpf/bpf_rlimit.h      | 28 -------------------
>> .../selftests/bpf/flow_dissector_load.c       |  1 -
>> .../selftests/bpf/get_cgroup_id_user.c        |  1 -
>> .../bpf/prog_tests/select_reuseport.c         |  1 -
>> .../selftests/bpf/prog_tests/sk_lookup.c      |  1 -
>> tools/testing/selftests/bpf/test_btf.c        |  1 -
>> .../selftests/bpf/test_cgroup_storage.c       |  1 -
>> tools/testing/selftests/bpf/test_dev_cgroup.c |  1 -
>> tools/testing/selftests/bpf/test_lpm_map.c    |  1 -
>> tools/testing/selftests/bpf/test_lru_map.c    |  1 -
>> tools/testing/selftests/bpf/test_maps.c       |  1 -
>> tools/testing/selftests/bpf/test_netcnt.c     |  1 -
>> tools/testing/selftests/bpf/test_progs.c      |  1 -
>> .../selftests/bpf/test_skb_cgroup_id_user.c   |  1 -
>> tools/testing/selftests/bpf/test_sock.c       |  1 -
>> tools/testing/selftests/bpf/test_sock_addr.c  |  1 -
>> .../testing/selftests/bpf/test_sock_fields.c  |  1 -
>> .../selftests/bpf/test_socket_cookie.c        |  1 -
>> tools/testing/selftests/bpf/test_sockmap.c    |  1 -
>> tools/testing/selftests/bpf/test_sysctl.c     |  1 -
>> tools/testing/selftests/bpf/test_tag.c        |  1 -
>> .../bpf/test_tcp_check_syncookie_user.c       |  1 -
>> .../testing/selftests/bpf/test_tcpbpf_user.c  |  1 -
>> .../selftests/bpf/test_tcpnotify_user.c       |  1 -
>> tools/testing/selftests/bpf/test_verifier.c   |  1 -
>> .../testing/selftests/bpf/test_verifier_log.c |  2 --
>> 27 files changed, 55 deletions(-)
>> delete mode 100644 tools/testing/selftests/bpf/bpf_rlimit.h
>> 
> 
> [...]