RE: [PATCH 3/3] ASoC: max98390: update dsm param bin max size

From: Steve Lee
Date: Mon Jul 27 2020 - 21:14:31 EST


> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Monday, July 27, 2020 10:08 PM
> To: Steve Lee <SteveS.Lee@xxxxxxxxxxxxxxxxxxx>
> Cc: lgirdwood@xxxxxxxxx; perex@xxxxxxxx; tiwai@xxxxxxxx;
> ckeepax@xxxxxxxxxxxxxxxxxxxxx; geert@xxxxxxxxxxxxxx;
> rf@xxxxxxxxxxxxxxxxxxxxxxxxxxx; shumingf@xxxxxxxxxxx;
> srinivas.kandagatla@xxxxxxxxxx; krzk@xxxxxxxxxx; dmurphy@xxxxxx;
> jack.yu@xxxxxxxxxxx; nuno.sa@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> alsa-devel@xxxxxxxxxxxxxxxx; ryan.lee.maxim@xxxxxxxxx; Ryan Lee
> <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>; steves.lee.maxim@xxxxxxxxx
> Subject: Re: [PATCH 3/3] ASoC: max98390: update dsm param bin max size
>
> On Mon, Jul 27, 2020 at 02:00:09AM +0000, Steve Lee wrote:
>
> > > I'm missing patches 1-2 and have no cover letter - what's the story
> > > with dependencies?
>
> > I will re-send patch ang please ignore this patch.
> > DSM init param is extended to cover more register so that DSM MAX PARAM
> SIZE value is changed.
>
> I applied these on Friday having found the other two patches (you're not sending
> things as a thread so they get lost, for example if someone sends a big series at
> a similar time like what happened on Friday) so your new version won't apply,
> please resend whatever change you want to make as an incremental patch
> against current code.

>
> Please do not submit new versions of already applied patches, please submit
> incremental updates to the existing code. Modifying existing commits creates
> problems for other users building on top of those commits so it's best practice
> to only change pubished git commits if absolutely essential.

Thanks, I missed patched was already applied. I will send patch upon these patches later.