Re: [PATCH][next] watchdog: sc1200wdt: Use fallthrough pseudo-keyword

[Guenter Roeck]

On 7/27/20 12:27 PM, Gustavo A. R. Silva wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1].
> 
> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/sc1200wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/sc1200wdt.c b/drivers/watchdog/sc1200wdt.c
> index 9673eb12dacd..f22ebe89fe13 100644
> --- a/drivers/watchdog/sc1200wdt.c
> +++ b/drivers/watchdog/sc1200wdt.c
> @@ -234,7 +234,7 @@ static long sc1200wdt_ioctl(struct file *file, unsigned int cmd,
>  			return -EINVAL;
>  		timeout = new_timeout;
>  		sc1200wdt_write_data(WDTO, timeout);
> -		/* fall through - and return the new timeout */
> +		fallthrough;	/* and return the new timeout */
>  
>  	case WDIOC_GETTIMEOUT:
>  		return put_user(timeout * 60, p);
>