Re: [net-next v4 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

[David Miller]

From: Vadym Kochan <vadym.kochan@xxxxxxxxxxx>
Date: Mon, 27 Jul 2020 15:22:37 +0300

> +	/* called by device driver to pass event up to the higher layer */
> +	int (*recv_msg)(struct prestera_device *dev, u8 *msg, size_t size);
> +
> +	/* called by higher layer to send request to the firmware */
> +	int (*send_req)(struct prestera_device *dev, u8 *in_msg,
> +			size_t in_size, u8 *out_msg, size_t out_size,
> +			unsigned int wait);

If you type "msg", "in_msg", and "out_msg" as (void *) you can remove
a lot of unnecessary casts in this driver.

Thank you.