Re: [PATCH] nilfs2: only call unlock_new_inode() if I_NEW

From: Ryusuke Konishi
Date: Mon Jul 27 2020 - 12:59:59 EST


Yeah, I sent this to Andrew a little while ago:

https://lkml.org/lkml/2020/7/27/976

Thanks,
Ryusuke Konishi

On Tue, Jul 28, 2020 at 1:50 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> On Sun, Jun 28, 2020 at 12:01:52AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> >
> > unlock_new_inode() is only meant to be called after a new inode has
> > already been inserted into the hash table. But nilfs_new_inode() can
> > call it even before it has inserted the inode, triggering the WARNING in
> > unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
> > inode has the I_NEW flag set, indicating that it's in the table.
> >
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Ping. Ryusuke, any interest in taking this patch?
>
> - Eric