Re: [PATCH] qed: fix assignment of n_rq_elems to incorrect params field

From: Jason Gunthorpe
Date: Mon Jul 27 2020 - 12:17:52 EST


On Mon, Jul 27, 2020 at 03:17:12PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently n_rq_elems is being assigned to params.elem_size instead of the
> field params.num_elems. Coverity is detecting this as a double assingment
> to params.elem_size and reporting this as an usused value on the first
> assignment. Fix this.
>
> Addresses-Coverity: ("Unused value")
> Fixes: b6db3f71c976 ("qed: simplify chain allocation with init params struct")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
> drivers/infiniband/hw/qedr/verbs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

DaveM will need to take this since the Fixed patch is in his tree,
thanks.

Jason