Re: [PATCH 2/6] rtlwifi: Remove unnecessary parenthese in rtl_dbg uses

[Pkshih]

On Sat, 2020-07-25 at 12:55 -0700, Joe Perches wrote:
> Make these statements a little simpler.
> 
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---
> Âdrivers/net/wireless/realtek/rtlwifi/base.cÂÂÂ| 14 +++++------
> Â.../rtlwifi/btcoexist/halbtc8192e2ant.cÂÂÂÂÂÂÂ| 23 ++++++++++---------
> Â.../rtlwifi/btcoexist/halbtc8821a2ant.cÂÂÂÂÂÂÂ| 12 +++++-----
> Â.../realtek/rtlwifi/btcoexist/halbtcoutsrc.cÂÂ|ÂÂ9 ++++----
> Âdrivers/net/wireless/realtek/rtlwifi/pci.cÂÂÂÂ|ÂÂ2 +-
> Â5 files changed, 30 insertions(+), 30 deletions(-)
> 
> 

[...]

> diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> index 8d28c68f083e..f9a2d8a6730c 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c
> @@ -874,11 +874,10 @@ static void halbtc_display_wifi_status(struct
> btc_coexist *btcoexist,
> Â	seq_printf(m, "\n %-35s = %s / %s/ %s/ AP=%d ",
> Â		ÂÂÂ"Wifi freq/ bw/ traffic",
> Â		ÂÂÂgl_btc_wifi_freq_string[wifi_freq],
> -		ÂÂÂ((wifi_under_b_mode) ? "11b" :
> -		ÂÂÂÂgl_btc_wifi_bw_string[wifi_bw]),
> -		ÂÂÂ((!wifi_busy) ? "idle" : ((BTC_WIFI_TRAFFIC_TX ==
> -					ÂÂÂÂÂÂwifi_traffic_dir) ? "uplink" :
> -					ÂÂÂÂÂ"downlink")),
> +		ÂÂÂwifi_under_b_mode ? "11b" : gl_btc_wifi_bw_string[wifi_bw],
> +		ÂÂÂ(!wifi_busy ? "idle" :
> +		ÂÂÂÂwifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" :
> +		ÂÂÂÂ"downlink"),

I think this would be better

+		Â Â!wifi_busy ? "idle" :
+		Â Â(wifi_traffic_dir == BTC_WIFI_TRAFFIC_TX ? "uplink" :
+		ÂÂÂÂ"downlink"),



> Â		ÂÂÂap_num);
> Â
> Â	/* power status	Â*/
> diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c
> b/drivers/net/wireless/realtek/rtlwifi/pci.c
> index 1d0af72ee780..3189d1c50d52 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/pci.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
> @@ -557,7 +557,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int
> prio)
> Â		if (rtlpriv->rtlhal.earlymode_enable)
> Â			skb_pull(skb, EM_HDR_LEN);
> Â
> -		rtl_dbg(rtlpriv, (COMP_INTR | COMP_SEND), DBG_TRACE,
> +		rtl_dbg(rtlpriv, COMP_INTR | COMP_SEND, DBG_TRACE,
> Â			"new ring->idx:%d, free: skb_queue_len:%d, free:
> seq:%x\n",
> Â			ring->idx,
> Â			skb_queue_len(&ring->queue),