Re: [RFC PATCH v4 05/14] i2c: tegra: Avoid tegra_i2c_init_dma() for Tegra210 vi i2c

[Dmitry Osipenko]

24.07.2020 02:51, Sowjanya Komatineni ÐÐÑÐÑ:
> VI I2C is on host1x bus so APB DMA can't be used for Tegra210 VI
> I2C and there are no tx and rx dma channels for VI I2C.
> 
> So, avoid attempt of requesting DMA channels.
> 
> Signed-off-by: Sowjanya Komatineni <skomatineni@xxxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
> index 1bf3666..00d3e4d 100644
> --- a/drivers/i2c/busses/i2c-tegra.c
> +++ b/drivers/i2c/busses/i2c-tegra.c
> @@ -421,7 +421,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
>  	dma_addr_t dma_phys;
>  	int err;
>  
> -	if (!i2c_dev->hw->has_apb_dma)
> +	if (!i2c_dev->hw->has_apb_dma || i2c_dev->is_vi)
>  		return 0;
>  
>  	if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
> 

Reviewed-by: Dmitry Osipenko <digetx@xxxxxxxxx>